[Cbe-oss-dev] [PATCH 2.6.23] PS3: Ignore storage devices that are still being probed

[Michael Ellerman]

On Fri, 2007-09-07 at 11:43 +0200, Geert Uytterhoeven wrote:
> On Fri, 7 Sep 2007, Michael Ellerman wrote:
> > On Fri, 2007-09-07 at 01:49 -0700, Geoff Levand wrote:
> > > Geert Uytterhoeven wrote:
> > > > PS3: A storage device may show up in the repository before the hypervisor has
> > > > finished probing:
> > > >   - If its type is not yet known, it shows up as PS3_DEV_TYPE_STOR_DUMMY,
> > > >   - If its regions are being probed, it shows up as having zero regions.
> > > > If any of these happen, consider the device not yet present.  The storage
> > > > probe thread will retry later.
> > > > 
> > > > This fixes the timing-dependent problem where a kernel booted from FLASH ROM
> > > > sometimes cannot find the hard disk.
> > > > 
> > > > Signed-off-by: Geert Uytterhoeven <Geert.Uytterhoeven at sonycom.com>
> > > 
> > > Paul,
> > > 
> > > This fixes a problem reported by users, so it would be nice for it to go
> > > in for 2.6.23 if possible.  Sorry for it being so late. 
> > 
> > Does it only happen when booting from flash? If so why? I'm seeing the
> > same symptom (hard disk not showing up), but booting from kboot.
> 
> So far we've seen it ourselves when booting from flash only. That doesn't
> necessarily mean it cannot happen when booting from kboot.
> 
> It depends a lot on timing: firmware version, hard disk model, kernel config,
> cold or warm boot, ... That's why it was so hard to track down.

OK. We've been cold booting into kboot and pretty quickly booting the
2nd kernel, so I guess it's possible we're hitting this.

> Does the patch fix the problem for you?

We haven't tried, will have to give it a go on Monday.

> What kernel are you using the first place?

-rc5 or thereabouts.

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070907/f173131f/attachment.pgp>