[Cbe-oss-dev] [PATCH 2/2] spufs: make state_mutex interruptible

[Arnd Bergmann]

On Wednesday 28 November 2007, Christoph Hellwig wrote:
> 
> > Cool stuff. On a related note, do we still want to keep the spu_acquire()/
> > spu_release() naming? It may be clearer to use mutex_lock_interruptible()
> > and a manual spu_deactivate() instead.
> 
> I wouldn't mind using plain mutex_lock_interruptible.  You mean the
> manual spu_deactivate for spu_acquire_saved?  Note sure about those - 
> spu_acquire_saved is quite a bit of code that's repeated in various
> places and the counterpart, spu_release_saved is non-trivial aswell.
> I'd prefer to keep those two at least.

Yes, that makes sense.

	Arnd <><