[Cbe-oss-dev] [PATCH 2/2] spufs: make state_mutex interruptible

[Christoph Hellwig]

On Wed, Nov 28, 2007 at 02:50:00PM +0100, Arnd Bergmann wrote:
> On Tuesday 27 November 2007, Christoph Hellwig wrote:
> > Make most places that use spu_acquire/spu_acquire_saved interruptible,
> > this allows getting out of the spufs code when e.g. pressing ctrl+c.
> 
> Cool stuff. On a related note, do we still want to keep the spu_acquire()/
> spu_release() naming? It may be clearer to use mutex_lock_interruptible()
> and a manual spu_deactivate() instead.

I wouldn't mind using plain mutex_lock_interruptible.  You mean the
manual spu_deactivate for spu_acquire_saved?  Note sure about those - 
spu_acquire_saved is quite a bit of code that's repeated in various
places and the counterpart, spu_release_saved is non-trivial aswell.
I'd prefer to keep those two at least.

> The reason for which we originally
> introduced separate functions has long disappeared, except for
> spu_acquire_runnable, and we're about to get rid of that as well.

It's already gone in the tree this patch is against..