[Cbe-oss-dev] [RFC/PATCH] libspe2: use mapped mailbox registers to speed up mailbox communication

[Gerhard Stenzel]

Kazunori Asayama <asayama at sm.sony.co.jp> wrote on 05/22/2007 10:47:48 AM:

> stenzel at de.ibm.com wrote:
...
> > Comments are still appreciated.
>
> Here are my comments:

thanks

> +static __inline__ int _base_spe_out_mbox_read_ps(spe_context_ptr_t
spectx,
> +                        unsigned int mbox_data[],
> +                        int count)
...
> This line must be:
>
>       if (entries > count - rc) entries = count - rc;

ok, I also changed the variable name from "rc" to "total" now, to be more
in sync with _base_spe_in_mbox_write_ps

...
> > @@ -200,23 +311,39 @@ int _base_spe_out_intr_mbox_read(spe_con
> >                          unsigned int data )
> >  {
> >     int rc;
> > +   volatile struct spe_spu_control_area *cntl_area =
> > +           spectx->base_private->cntl_mmap_base;
>
> The variable cntl_area is not used.

hm, something went wrong when creating the patch .. I will do it again and
resend

Best regards,

Gerhard Stenzel, Linux on Cell Development, LTC
-----------------------------------------------------------------------------------------------------------------------------------

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter | Geschäftsführung: Herbert
Kircher
Sitz der Gesellschaft: Böblingen | Registergericht: Amtsgericht Stuttgart,
HRB 243294