[Cbe-oss-dev] [patch 10/18] Add support to OProfile for profiling Cell BE SPUs

[Jeremy Kerr]

Maynard,

> I went through the patch and most of the "whitespace changes" are
> extra lines that were probably intentionally added for readabilty. 
> Granted, there are a few extra or deleted lines that were likely
> unintentional. Specifically, which whitespace changes were you going
> to remove?

There's a few changes in that patch. Things like:


@@ -287,7 +289,7 @@ static void spu_prio_wait(struct spu_con
  * spu_reschedule - try to find a runnable context for a spu
  * @spu:       spu available
  *
- * This function is called whenever a spu becomes idle.  It looks for the
+ * This function is called whenever a spu becomes idle.          It looks for the
  * most suitable runnable spu context and schedules it for execution.
  */ 
 static void spu_reschedule(struct spu *spu)


@@ -460,7 +462,7 @@ void spu_deactivate(struct spu_context *
 }

 /**
- * spu_yield -  yield a physical spu if others are waiting
+ * spu_yield - yield a physical spu if others are waiting
  * @ctx:       spu context to yield
  *
  * Check if there is a higher priority context waiting and if yes


@@ -576,7 +578,7 @@ aff_ref_location(int mem_aff, int group_
        int node, n;
 
        /* TODO: A better algorithm could be used to find a good spu to be
-        *       used as reference location for the ctxs chain.
+        *       used as reference location for the ctxs chain.
         */
        node = cpu_to_node(raw_smp_processor_id());
        for (n = 0; n < MAX_NUMNODES; n++, node++) {

This just ends up creating more merge conflicts :(

However, Arnd has sent this patch to paulus, so we shouldn't see any
merge conflicts any more :)

Cheers,


Jeremy