[Cbe-oss-dev] [patch 10/18] Add support to OProfile for profiling Cell BE SPUs

[Maynard Johnson]

Jeremy Kerr wrote:

>Paul,
>
>On Saturday 28 April 2007, Arnd Bergmann wrote:
>  
>
>>From: Maynard Johnson <mpjohn at us.ibm.com>
>>
>>This patch updates the existing arch/powerpc/oprofile/op_model_cell.c
>>to add in the SPU profiling capabilities.  In addition, a 'cell'
>>subdirectory was added to arch/powerpc/oprofile to hold Cell-specific
>>SPU profiling code.
>>
>>Signed-off-by: Carl Love <carll at us.ibm.com>
>>Signed-off-by: Maynard Johnson <mpjohn at us.ibm.com>
>>Signed-off-by: Arnd Bergmann <arnd.bergmann at de.ibm.com>
>>
>>    
>>
>
>
>I'm happy for the spufs component of this patch to go in, minus 
>whitespace changes. I can create a patch with these separated out if 
>you like.
>  
>
I went through the patch and most of the "whitespace changes" are extra 
lines that were probably intentionally added for readabilty.  Granted, 
there are a few extra or deleted lines that were likely unintentional.  
Specifically, which whitespace changes were you going to remove?

>However, I'd like someone with more oprofile knowledge to check this 
>before we merge the rest.
>  
>
I'm not currently doing Cell development anymore, but I could probably 
find the time and a system to do the testing if you go ahead with making 
a new patch.

Regards,
-Maynard

>Cheers,
>
>
>Jeremy
>_______________________________________________
>cbe-oss-dev mailing list
>cbe-oss-dev at ozlabs.org
>https://ozlabs.org/mailman/listinfo/cbe-oss-dev
>  
>