[Cbe-oss-dev] [RFC/PATCH 2/2] spufs: Add a "capabilities" file to spu contexts

[Christoph Hellwig]

On Fri, Jun 01, 2007 at 10:06:52AM +1000, Michael Ellerman wrote:
> On Thu, 2007-05-31 at 21:36 +0200, Christoph Hellwig wrote:
> > On Thu, May 31, 2007 at 09:35:15PM +0200, Christoph Hellwig wrote:
> > > On Fri, May 25, 2007 at 02:54:05PM +1000, Benjamin Herrenschmidt wrote:
> > > > This adds a "capabilities" file to spu contexts consisting of a
> > > > list of space separated capability names. The current exposed
> > > > capabilities are "sched" (the context is scheduleable) and
> > > > "step" (the context supports single stepping).
> > > 
> > > I don't like the handcrafted buffer printing.  The patch below does
> > > a seq_file version instead.  This has one notable difference in the
> > > output because it always prints an whitespace before the newline
> > > at the end to keep the code simpler.  This should be perfectly fine
> > > for any reasonable parser.
> 
> Why not just put each cap on a new line? eg:
> 
> seq_puts(s, "sched\n");

Fine with me.  Ben do you have any preferences?