[Cbe-oss-dev] [RFC/PATCH 2/2] spufs: Add a "capabilities" file to spu contexts

[Michael Ellerman]

On Thu, 2007-05-31 at 21:36 +0200, Christoph Hellwig wrote:
> On Thu, May 31, 2007 at 09:35:15PM +0200, Christoph Hellwig wrote:
> > On Fri, May 25, 2007 at 02:54:05PM +1000, Benjamin Herrenschmidt wrote:
> > > This adds a "capabilities" file to spu contexts consisting of a
> > > list of space separated capability names. The current exposed
> > > capabilities are "sched" (the context is scheduleable) and
> > > "step" (the context supports single stepping).
> > 
> > I don't like the handcrafted buffer printing.  The patch below does
> > a seq_file version instead.  This has one notable difference in the
> > output because it always prints an whitespace before the newline
> > at the end to keep the code simpler.  This should be perfectly fine
> > for any reasonable parser.

Why not just put each cap on a new line? eg:

seq_puts(s, "sched\n");

cheers

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
URL: <http://lists.ozlabs.org/pipermail/cbe-oss-dev/attachments/20070601/a8c6bcf8/attachment.pgp>