[Cbe-oss-dev] [patch 04/16] Common Core of the Axon driver

[Benjamin Herrenschmidt]

On Fri, 2007-05-25 at 10:47 +0200, Jean-Christophe Dubois wrote:
> > > +   p_dma_pkt->addr =
> > > +       dma_pool_alloc(p_dma_req->p_dma_pool, GFP_ATOMIC,
> > > +                      &p_dma_pkt->cpu_bus_addr);
> >
> > Do you plan to port this to an ISA based system? Seriously, on a
> modern
> > system you don't want to use dma_pool interfaces. Just use the
> dma-mapping
> > API.
> 
> This is to allocate the command packets for the DMA. It seemed
> appropriate ... 
> For the data transferred by the DMA we are using the dma-mapping API.
> Do you 
> think I should create/manage my own pool of DMA command packets? 

BTW, GFP_ATOMIC is likely to fail...

Ben.