[Cbe-oss-dev] [PATCH] spufs: remove harmful initialize code

Arnd Bergmann arnd at arndb.de
Mon Jul 23 20:09:34 EST 2007


On Monday 23 July 2007, Masato Noguchi wrote:
> 
> This patch is a bugfix against for v2.6.23-rc1. And this bug will
> affects all cell platforms, I think.
> 
> This patch remove the harmful initialize code at spufs/sched.c.

Yes, this looks like a mismerge on my part, when merging Christoph's
locking cleanup with the oprofile patch.

Christoph, could you take a quick look to make sure it's the
right fix?
 
> This code clears cbe_spu_info[].spus.  But same initialization was
> already performed at spu_base.c, and at a time, cbe_spu_info[].spus
> was initialized as a meaningful list. As a result, re-initialize code
> deletes important informations to run spe.
> 
> Signed-off-by: Masato Noguchi <Masato.Noguchi at jp.sony.com>

Acked-by: Arnd Bergmann <arnd.bergmann at de.ibm.com>



More information about the cbe-oss-dev mailing list