[Cbe-oss-dev] [PATCH] spufs: remove harmful initialize code

Masato Noguchi Masato.Noguchi at jp.sony.com
Mon Jul 23 19:54:33 EST 2007


This patch is a bugfix against for v2.6.23-rc1. And this bug will
affects all cell platforms, I think.

This patch remove the harmful initialize code at spufs/sched.c.

This code clears cbe_spu_info[].spus.  But same initialization was
already performed at spu_base.c, and at a time, cbe_spu_info[].spus
was initialized as a meaningful list. As a result, re-initialize code
deletes important informations to run spe.

Signed-off-by: Masato Noguchi <Masato.Noguchi at jp.sony.com>
---

 arch/powerpc/platforms/cell/spufs/sched.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/platforms/cell/spufs/sched.c b/arch/powerpc/platforms/cell/spufs/sched.c
index 227968b..758a80a 100644
--- a/arch/powerpc/platforms/cell/spufs/sched.c
+++ b/arch/powerpc/platforms/cell/spufs/sched.c
@@ -927,10 +927,6 @@ int __init spu_sched_init(void)
 		INIT_LIST_HEAD(&spu_prio->runq[i]);
 		__clear_bit(i, spu_prio->bitmap);
 	}
-	for (i = 0; i < MAX_NUMNODES; i++) {
-		mutex_init(&cbe_spu_info[i].list_mutex);
-		INIT_LIST_HEAD(&cbe_spu_info[i].spus);
-	}
 	spin_lock_init(&spu_prio->runq_lock);
 
 	setup_timer(&spusched_timer, spusched_wake, 0);




More information about the cbe-oss-dev mailing list