[Cbe-oss-dev] [PATCH] ps3_storage scheduling while atomic

[Geert Uytterhoeven]

	Hi Florin,

On Sun, 28 Jan 2007, Florin Malita wrote:
> Florin Malita wrote:
> > While testing the latest PS3 patchset, I tried enabling CONFIG_PREEMPT 
> > and the storage driver triggered this:
> >
> > BUG: scheduling while atomic: ps3stor-1-0/0x00000001/183
> > Call Trace:
> > [C000000001B17AB0] [C00000000000F7D4] .show_stack+0x54/0x1f0 (unreliable)
> > [C000000001B17B60] [C000000000288C94] .schedule+0xbb4/0xc70
> > [C000000001B17CC0] [C000000000288EC8] .wait_for_completion+0xb8/0x140
> > [C000000001B17D80] [C0000000001B5704] .ps3_stor_common_handle_write+0x104/0x260
> > [C000000001B17E40] [C0000000001B5AC8] .ps3_stor_main_thread+0x108/0x160
> > [C000000001B17EE0] [C000000000067548] .kthread+0x158/0x170
> > [C000000001B17F90] [C000000000021D18] .kernel_thread+0x4c/0x68
> > ...
> >
> >
> > Both ps3_stor_common_handle_read() and ps3_stor_common_handle_write() 
> > call wait_for_completion() while holding a rw spinlock 
> > (dev_info->bounce_lock). Looks like the only race is with 
> > ps3_stor_set_max_sectors() so maybe there's a way to avoid locking 
> > altogether but in the meantime here's a patch converting it to a 
> > rw_semaphore.
> 
> Any plans to address this? Any input on the patch?

Sorry, in the mean time I haven't really looked at the storage driver anymore
(busy with ps3av and ps3fb). I'll resume storage work soon.

Anyway, thanks for your patch!

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
Geert.Uytterhoeven at sonycom.com ------- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 ---------------- B-1935 Zaventem, Belgium