[Cbe-oss-dev] [PATCH] fix reboot fail on kexec for CBE

Benjamin Herrenschmidt benh at kernel.crashing.org
Wed Apr 4 11:20:43 EST 2007


On Tue, 2007-04-03 at 22:27 +0900, Akira Tsukamoto wrote:
> [PATCH] fix reboot fail on kexec for CBE
> 
> This patch adds additional TLB flush for dump-capture kernel to 
> successfully reboot triggered by kexec. 
> 
> The same issue might exist on PS3 platform but I have not tried 
> yet and the patch only applies to CBE platform.
> I really appreciate if somebody could brush up this patch, as such 
> using magic constant value inside the code.

Interesting... I was talking to Luke Browning the other day about the
proper way to flush the whole TLB (note that we also need to flush MFC's
TLBs) on cell. Our approach was to walk the hash table and issue a tlbie
for anything found in there, though that's pretty complicated.

It looks like you have some "magic" SPRs to do the job, care to provide
a bit more details about the approach ?

(In addition, you have the obvious bug that your patch will break a
common kernel booting on !cell and that flush should be useful for more
than just crash dump but also normal kexec).

Cheers,
Ben.





More information about the cbe-oss-dev mailing list