[Cbe-oss-dev] [RFC 1/9] AXON - common driver core

Benjamin Herrenschmidt benh at kernel.crashing.org
Thu Dec 28 10:12:22 EST 2006


On Fri, 2006-12-22 at 17:38 +0100, Jean-Christophe Dubois wrote:
> > better use out_be32
> 
> Think LE .. 

Note that the way you use raw_* accessors with wmb() is not completely
correct.

You probably should define your axon accessors differently for x86
and cell host, with the cell version using in/out_be*

In fact, you should split your base type & accessor definitions in two
headers, one for powerpc, one for x86, and include the right one (or
put the right one in the appropriate asm/)

Ben.
 




More information about the cbe-oss-dev mailing list