[PATCH 7/10] prom_getchar eats characters

Olof Johansson olof at lixom.net
Mon Apr 12 01:15:42 EST 2010


On Sun, Apr 11, 2010 at 02:05:59PM +1000, Anton Blanchard wrote:
> 
> This bug has been annoying me for a long time. If you copy and paste a
> string into the yaboot prompt, or even type too fast, characters get
> dropped.
> 
> It turns out we were asking OF for 4 characters, but only using the first one.
> There is strange logic to look for \e[, and then oring the third character with
> 0x100. I haven't been able to find anyone that knows why that was there in the
> first place, so just remove it and fix this bug once and for all.

My guess? To just silently drop vt100 arrow key codes. I don't think it'll
be missed, especially since it still doesn't handle the 4-character ones.

> Automated test infrastructures the world over will thank us for fixing this
> bug!

:)


-Olof


More information about the Yaboot-devel mailing list