long append="..." causes yaboot to reject entire yaboot.conf (MAX_TOKEN too small)

Roman Rakus rrakus at redhat.com
Thu Nov 13 21:59:43 EST 2008


Hello.

/From Will Woods (wwoods at redhat.com <mailto:wwoods at redhat.com>)/
"""

yaboot's second/cfg.c has:
  #define MAX_TOKEN 200

When yaboot parses its config file, if it encounters a quoted string (like
append="...") longer than MAX_TOKEN, it rejects the entire config.

Typical preupgrade usage uses ~250 chars, which means preupgrade currently
renders ppc systems unbootable without this patch.

Suggest increasing MAX_TOKEN to.. let's say 511. cfg.c does "char
buf[MAX_TOKEN+1]", and everyone loves powers of 2.
"""
Will it be in next release?
RR

-------------- next part --------------
A non-text attachment was scrubbed...
Name: yaboot-1.3.14-bigger-max-token.patch
Type: text/x-patch
Size: 393 bytes
Desc: not available
URL: <http://lists.ozlabs.org/pipermail/yaboot-devel/attachments/20081113/946ceac1/attachment.bin>


More information about the Yaboot-devel mailing list