My yaboot changes for PPCRCD

[Nathan Lynch]

Przemek Iskra wrote:
> On Sun, Mar 26, 2006 at 06:20:57PM -0500, Paul Nasrat wrote:
> > On Sun, 2006-03-26 at 22:22 +0200, Przemek Iskra wrote:
> > > I was working on yaboot (binary part only) for a while, because I need
> > > some additional functionality for my PPCRCD:
> > > 
> > > You can find my changes in PLD-linux's SVN:
> > > - http://svn.pld-linux.org/svn/ppcrcd/trunk/yaboot
> > > or throught web interface:
> > > - http://svn.pld-linux.org/cgi-bin/viewsvn/ppcrcd/trunk/yaboot/
> 
> > Can you break up patches into indivual sets and mail to list thanks.
> 
> there they are:
> 
> * yaboot-crt0.patch *
>   changes
> 	cmp	0,r10,r11
>   to
> 	cmp	0,0,r10,r11
>   I don't know what it is, but it was in my distribution
>   anyway, afert assembling it becomes:
>   	cmpw    r10,r11
> 
> * yaboot-net.patch *
>   fix file detection in network device-path on iBook G4

Can you tell us more about what the problem was?

...

> diff -Nurw yaboot-1.3.14rc1/second/file.c yaboot-ppcrcd/second/file.c
> --- yaboot-1.3.14rc1/second/file.c	2006-02-10 03:08:33.000000000 +0100
> +++ yaboot-ppcrcd/second/file.c	2006-03-10 23:16:09.000000000 +0100
> @@ -88,12 +88,14 @@
>        * filename.  Otherwise, we must advance args once more.
>        */
>       args++;
> +#if 0 // bullshit
>       if (*tmp != ':') {
>  	  args = strchr(args, ',');
>  	  if (!args)
>  	       return NULL;
>  	  args++;
>       }
> +#endif

Netbooting on other machines might be regressed without this bullshit
so please give us some more explanation of why this change is needed.
I went to the trouble of digging in your svn for the change history
but it wasn't helpful.