[snowpatch] [PATCH] jenkins: Get started on fixing error handling

Russell Currey ruscur at russell.cc
Mon Jan 14 16:32:21 AEDT 2019


On Fri, 2018-12-14 at 15:32 +1100, Andrew Donnellan wrote:
> We use unwrap() a lot. We should do less of that.
> 
> Get rid of a lot of the unwrap()s in the Jenkins code and return
> Result
> types with errors instead.
> 
> We haven't completely gotten rid of unwrap(), there's still some bits
> which
> are a bit gross, and on the main side we still just unwrap rather
> than
> handling the error properly.
> 
> At some point in the future, we might switch to using an external
> crate for
> the Jenkins API itself to make life a bit easier.
> 
> Signed-off-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

Tested and applied as 05227dada827341197a1a6a8ccdcc6075c6adbb3, thanks



More information about the snowpatch mailing list