[snowpatch] [PATCH 6/8] Clean up an unnecessary clone

Andrew Donnellan andrew.donnellan at au1.ibm.com
Mon Jul 23 11:07:20 AEST 2018


On 20/07/18 21:57, Russell Currey wrote:
> Signed-off-by: Russell Currey <ruscur at russell.cc>

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

> ---
>   src/main.rs | 12 +-----------
>   1 file changed, 1 insertion(+), 11 deletions(-)
> 
> diff --git a/src/main.rs b/src/main.rs
> index 027ceae..5d34b36 100644
> --- a/src/main.rs
> +++ b/src/main.rs
> @@ -251,22 +251,12 @@ fn test_patch(
>           let settings = settings.clone();
>           let project = project.clone();
>           let client = client.clone();
> -        let settings_clone = settings.clone();
>           let test_all_branches = project.test_all_branches.unwrap_or(true);
>   
>           // We've set up a remote branch, time to kick off tests
>           let test = thread::Builder::new()
>               .name(tag.to_string())
> -            .spawn(move || {
> -                run_tests(
> -                    &settings_clone,
> -                    client,
> -                    &project,
> -                    &tag,
> -                    &branch_name,
> -                    hefty_tests,
> -                )
> -            })
> +            .spawn(move || run_tests(&settings, client, &project, &tag, &branch_name, hefty_tests))
>               .unwrap();
>           results.append(&mut test.join().unwrap());
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the snowpatch mailing list