[snowpatch] [PATCH 1/8] Convert from hyper to reqwest

Andrew Donnellan andrew.donnellan at au1.ibm.com
Mon Jul 23 10:15:48 AEST 2018


On 20/07/18 21:57, Russell Currey wrote:
> There's a bit going on here but it's hard to separate without breaking bisect.
> 
> Firstly, convert from hyper to reqwest.  We have no need for asynchronous HTTP

*yet* ;)

> and the new hyper API isn't suitable for our needs, whereas reqwest is pretty
> close to what we originally used hyper for, except somewhat simpler.
> 
> Next, update the rest of the dependencies to their latest major versions.
> This *just compiled*.
> 
> Lastly, change the Jenkins HTTP helpers to be a bit more like the Patchwork
> ones.  This worked around an issue with different return types and seemed like
> the simplest solution.
> 
> Signed-off-by: Russell Currey <ruscur at russell.cc>

This all looks okay.

Reviewed-by: Andrew Donnellan <andrew.donnellan at au1.ibm.com>

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the snowpatch mailing list