[snowpatch] [PATCH v2 5/5] jenkins: Only link to artifact if it actually exists

Andrew Donnellan andrew.donnellan at au1.ibm.com
Tue Dec 11 19:21:07 AEDT 2018



On 11/12/18 2:46 pm, Russell Currey wrote:
> Signed-off-by: Russell Currey <ruscur at russell.cc>
> ---
>   src/jenkins.rs | 14 ++++++++++++--
>   1 file changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/src/jenkins.rs b/src/jenkins.rs
> index 1fbcc49..67d729e 100644
> --- a/src/jenkins.rs
> +++ b/src/jenkins.rs
> @@ -191,9 +191,19 @@ impl JenkinsBackend {
>       }
>   
>       pub fn get_results_url(&self, build_url: &str, job: &BTreeMap<String, String>) -> String {
> +        let default_url = format!("{}/", build_url);
>           match job.get("artifact") {
> -            Some(artifact) => format!("{}/artifact/{}", build_url, artifact),
> -            None => format!("{}/", build_url),
> +            Some(artifact) => {
> +                let artifact_url = format!("{}/artifact/{}", build_url, artifact);
> +                match self.get_url(&artifact_url) {
> +                    Ok(mut resp) => match resp.status().is_success() {
> +                        true => artifact_url,
> +                        false => default_url,

same comment as last patch

> +                    },
> +                    Err(_e) => default_url,
> +                }
> +            }
> +            None => default_url,
>           }
>       }
>   
> 

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited



More information about the snowpatch mailing list