[snowpatch] [PATCH V2 1/2] Update deps, bumping url crate to 1.1
Andrew Donnellan
andrew.donnellan at au1.ibm.com
Wed May 25 16:03:29 AEST 2016
On 25/05/16 14:21, Russell Currey wrote:
> Update the url crate up to 1.1, introducing breaking changes.
> Fix these breakages in the jenkins code.
>
> Also, bump up point releases of the rest of the deps.
>
> Signed-off-by: Russell Currey <ruscur at russell.cc>
...
> diff --git a/src/jenkins.rs b/src/jenkins.rs
> index 4a69ddc..dc22737 100644
> --- a/src/jenkins.rs
> +++ b/src/jenkins.rs
> @@ -55,7 +55,11 @@ impl<'a> CIBackend for JenkinsBackend<'a> {
> fn start_test(&self, job_name: &str, params: Vec<(&str, &str)>)
> -> Result<String, &'static str> {
> let client = Client::new(); // TODO: do we want to get this from somewhere else?
> - let params = url::form_urlencoded::serialize(params);
> + let mut serializer = url::form_urlencoded::Serializer::new(String::new());
> + for param in params {
> + serializer.append_pair(param.0, param.1);
> + }
> + let params = serializer.finish();
As per discussion, I changed this to:
let params = url::form_urlencoded::Serializer::new(String::new())
.extend_pairs(params)
.finish();
to be a bit less awful.
Applied to master: 56b5eef10ea46746732ea56fa52383437abfbfcd
--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com IBM Australia Limited
More information about the snowpatch
mailing list