[snowpatch] [PATCH] Replace ssh agent authentication with explicit key
Russell Currey
ruscur at russell.cc
Fri Dec 2 11:50:00 AEDT 2016
On Fri, 2016-12-02 at 11:28 +1100, Andrew Donnellan wrote:
> On 01/12/16 17:04, Andrew Donnellan wrote:
> > diff --git a/src/settings.rs b/src/settings.rs
> > index a4a5614..b440885 100644
> > --- a/src/settings.rs
> > +++ b/src/settings.rs
> > @@ -28,6 +28,14 @@ use std::collections::BTreeMap;
> > // TODO: Give more informative error messages when we fail to parse.
> >
> > #[derive(RustcDecodable, Clone)]
> > +pub struct Git {
> > + pub user: String,
> > + pub public_key: Option<String>,
> > + pub private_key: String,
>
> This should probably be Option as well.
It's mandatory, see http://alexcrichton.com/git2-rs/git2/struct.Cred.html
>
> > + pub passphrase: Option<String>
>
>
* We should probably enforce having either keys or passphrase...
>
> > +}
> > +
> > +#[derive(RustcDecodable, Clone)]
> > pub struct Patchwork {
> > pub url: String,
> > pub port: Option<u16>,
> > @@ -65,6 +73,7 @@ impl Project {
> >
> > #[derive(RustcDecodable, Clone)]
> > pub struct Config {
> > + pub git: Git,
> > pub patchwork: Patchwork,
> > pub jenkins: Jenkins,
> > pub projects: BTreeMap<String, Project>
> >
>
>
More information about the snowpatch
mailing list