[snowpatch] [PATCH] Replace ssh agent authentication with explicit key

[Andrew Donnellan]

On 01/12/16 17:04, Andrew Donnellan wrote:
> From: Russell Currey <ruscur at russell.cc>
>
> libgit2 has a long-standing obscure bug where it gets in an infinite loop
> calling ssh-agent.  ssh-agent has been a pain point in snowpatch for a
> while now, so let's just not use it - instead, manually specify public and
> private keys.  This adds the benefit of configuring the user ("git" was
> hardcoded for GitHub/GitLab previously) as well as passphrase support.
>
> Future possibility: support parsing "~/" in the settings file.
>
> Signed-off-by: Russell Currey <ruscur at russell.cc>

The only reservations I have about this patch:

* It would be nice if we could still fall back on ssh-agent for the 
circumstances where the libgit2 bug doesn't get exposed

* Different projects can use different git remotes which in turn could 
require different usernames or keys

Thoughts?

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan at au1.ibm.com  IBM Australia Limited