[SLOF] [PATCH v4] slof/fs/packages/disk-label.fs: improve checking for DOS boot partitions

Kautuk Consul kconsul at linux.ibm.com
Fri May 3 20:08:41 AEST 2024


Hi Alexey/Segher,

> > :-). But this is the only other path that doesn't have a CATCH
> > like the do-load subroutine in slof/fs/boot.fs. According to Segher
> > there shouldn't ever be a problem with throw because if nothing else the
> > outer-most interpreter loop's CATCH will catch the exception. But I
> > thought to cover this throw in read-sector more locally in places near
> > to this functionality. Because the outermost FORTH SLOF interpreter loop is not
> > really so related to reading a sector in disk-label.fs.
> > 
> Alexey/Segher, so what should be the next steps ?
> Do you find my explanation above okay or should I simply remove these
> CATCH blocks ? Putting a CATCH block in count-dos-logical-partitions is
> out of the question as there is already a CATCH in do-load in
> slof/fs/boot.fs. This CATCH block in the open subroutine is actually to
> prevent the exception to be caught at some non-local place in the code.

Any ideas on how we proceed with this now ?

> _______________________________________________
> SLOF mailing list
> SLOF at lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/slof


More information about the SLOF mailing list