[SLOF] [PATCH 4/4] Fix typos in the slof folder

Alexey Kardashevskiy aik at ozlabs.ru
Tue Feb 28 17:08:46 AEDT 2023



On 23/02/2023 03:34, Segher Boessenkool wrote:
> On Wed, Feb 22, 2023 at 04:40:57PM +0100, Thomas Huth wrote:
>> Found with the "codespell" utility. I kept "busses" which codespell
>> also complains about since it seems to be an old but still valid
>> plural of the word "bus".
> 
> For all four:
> Reviewed-by: Segher Boessenkool <segher at kernel.crashing.org>
> 
>> -\ We corespond memory nodes with their respective memory controllers
>> +\ We correspond memory nodes with their respective memory controllers
>>   \ and use /chosen/memory as default memory node to hold the "available" map
> 
> "We pair"?  "We correlate"?
> 
>>   \ NOTE -> /chosen/memory is expected 2B initialized before using claim/release
> 
> "to be".  (It took me a while to realise this , I thought "0x80000000
> earlier" or such!)
> 
>>   \ check for multifunction and for each function
>> -\ (dependig from header type) call device or bridge setup
>> +\ (depending from header type) call device or bridge setup
> 
> "dependent on header type"?
> 
>> -// bool dependend pick
>> +// bool dependent pick
>>   // ?PICK ( v1 v2 bool -- v1|v2 )
> 
> : ?pick  1 umin pick ;

What is "umin" exactly?

> or
> : ?pick  IF swap THEN drop ;
> (the latter is the actual implementation).
> 
> But maybe just delete this word?  It isn't used anywhere afaics, and it
> isn't a good name for what it does anyway?

Delete it is then:

https://github.com/aik/SLOF-debug/commits/master



-- 
Alexey


More information about the SLOF mailing list