[SLOF] [PATCH 2/4] tcgbios: Add implementations for sha1, sha384, and sha512

[Alexey Kardashevskiy]

On 28/06/2021 21:39, Stefan Berger wrote:
> 
> On 6/28/21 3:45 AM, Alexey Kardashevskiy wrote:
>>
>>> @@ -90,7 +90,7 @@ static void sha256_block(uint32_t *w, sha256_ctx *ctx)
>>>        *
>>>        *  0 <= i <= 15:
>>>        *    W(t) = M(t)
>>> -     * 16 <= i <= 79:
>>> +     * 16 <= i <= 63:
>>
>>
>> What is this change about? Thanks,
> 
> 
> Code comment was wrong. That's all.

There was no commit log so it really looks like an 50/50 accident or the 
code was wrong too but the change got lost.

> 
> All see pdf page 24 (doc page 19) bottom here: 
> https://csrc.nist.gov/csrc/media/publications/fcoips/180/2/archive/2002-08-01/documents/fips180-2.pdf 

And the code does not need fixing? I mean I cannot see it from the mail 
and I have to open the code and search myself (so yeah, the code seems 
correct already), a short note would make me not do that :)


-- 
Alexey