[SLOF] [PATCH v3 2/7] tcgbios: Use assembly for 32 bit rotr in sha256

Alexey Kardashevskiy aik at ozlabs.ru
Fri Jul 9 23:56:01 AEST 2021

On 09/07/2021 23:52, Stefan Berger wrote:
> On 7/9/21 1:35 AM, Alexey Kardashevskiy wrote:
>> On 09/07/2021 12:53, Stefan Berger wrote:
>>> From: Stefan Berger <stefanb at linux.ibm.com>
>>> Use assembly for the 32 bit rotr in the sha256 implementation.
>> Why bother with asm here?
> I used assembly now for rotation for all the other ones and so I though 
> I'd convert this one as well.

Then add this to the commit log please, it is not that self-explanatory 
and may give wrong impression that this is somehow performance critical 
or something :) Thanks,


More information about the SLOF mailing list