[SLOF] [PATCH 4/4] Add testprograms

Stefan Berger stefanb at linux.ibm.com
Fri Jul 9 00:49:40 AEST 2021


On 7/1/21 2:38 AM, Thomas Huth wrote:
> On 01/07/2021 06.11, Alexey Kardashevskiy wrote:
>>
>>
>> On 30/06/2021 22:26, Stefan Berger wrote:
>>>
>>> On 6/29/21 11:10 PM, Alexey Kardashevskiy wrote:
>>>> What does this actually test? It runs sha384/etc but it is not 
>>>> comparing the outcome with known good values or anything like this.
>>>>
>>> I visually compared the results against the expected results from 
>>> test vectors or results from  command line output of echo -n "..." | 
>>> sha512sum for example.
>>
>> if would make more sense if you hardcoded those outputs to the test 
>> and compared, then the next reader won't have questions and will know 
>> exactly what it tests.
>
> Bonus points for turning these into proper unit tests that could be 
> run in github actions or another CI system (Travis-CI provides free 
> ppc64le runners if that's of any help).

V2 that I just posted will be very easy to run in a CI system, but ... 
travis-ci.org is shut down now and travis-ci.com is for paying customers 
afaik, at least I pay for it. So if one uses only ppc64le runners then 
they are free?



>
>  Thomas
>


More information about the SLOF mailing list