[SLOF] [PATCH 4/4] Add testprograms

Stefan Berger stefanb at linux.ibm.com
Wed Jul 7 07:32:58 AEST 2021


On 7/1/21 12:11 AM, Alexey Kardashevskiy wrote:
>
>
> On 30/06/2021 22:26, Stefan Berger wrote:
>>
>> On 6/29/21 11:10 PM, Alexey Kardashevskiy wrote:
>>> What does this actually test? It runs sha384/etc but it is not 
>>> comparing the outcome with known good values or anything like this.
>>>
>> I visually compared the results against the expected results from 
>> test vectors or results from  command line output of echo -n "..." | 
>> sha512sum for example.
>
> if would make more sense if you hardcoded those outputs to the test 
> and compared, then the next reader won't have questions and will know 
> exactly what it tests.
>

So you really want to keep these test cases then? If so, can we use glib 
to make tings a bit easier for invoking external programs and getting 
results back?



More information about the SLOF mailing list