[SLOF] [PATCH slof 00/13] Compile with -Wextra
segher at kernel.crashing.org
Thu Jan 28 14:52:32 AEDT 2021
On Thu, Jan 28, 2021 at 01:23:24PM +1100, Alexey Kardashevskiy wrote:
> On 28/01/2021 10:02, Segher Boessenkool wrote:
> >On Wed, Jan 27, 2021 at 07:57:39PM +1100, Alexey Kardashevskiy wrote:
> >>Following the conversation at
> >>this enables -Wextra with the exception of -Wno-unused-parameter.
> >>This is a series to make possible bisecting easier.
> >>This is based on sha1
> >>6184ca06c8d8 Gustavo Romero "board-qemu: Fix comment about SLOF start
> >>Please comment. Thanks.
> >I commented on 2/13. I also don't like the casts in 11/13, but the code
> >does seem to do the right thing.
> >1/13 is actually a bugfix, no?
> I did not even realize that, good eye! :)
I typoed that, wow... 12/13! (It decreases "size" in every fallthrough
case, which might or might now work, bu is surely not intended).
> >Thank you for doing this,
> I kinda have to, as a slof emperor :)
There are emperors now? I'm jealous!
More information about the SLOF