[SLOF] [PATCH] Compile SLOF with -Wimplicit-fallthrough
Philippe Mathieu-Daudé
f4bug at amsat.org
Mon Jan 25 22:25:46 AEDT 2021
Hi Thomas,
On Sun, Jan 24, 2021 at 7:54 AM Thomas Huth <thuth at redhat.com> wrote:
>
> The -Wimplicit-fallthrough warnings help to catch bugs with forgotten
> "break" statements, so it's a good idea to have this switch enabled.
> Thus let's fix the current spots that generate warnings and add the
> switch to our WARNFLAGS.
>
> Signed-off-by: Thomas Huth <thuth at redhat.com>
> ---
> lib/libc/stdio/vsnprintf.c | 1 +
> make.rules | 4 +++-
> slof/prim.code | 3 +++
> 3 files changed, 7 insertions(+), 1 deletion(-)
I'd rather have 2 distinct patches, first C code, then buildsys. Since I don't
know the SLOF project preferences, up to you :)
In any case (this, or split in 2 patches):
Reviewed-by: Philippe Mathieu-Daudé <f4bug at amsat.org>
Thanks,
Phil.
More information about the SLOF
mailing list