[SLOF] [PATCH 2/3] virtio-serial: Rework shutdown sequence
segher at kernel.crashing.org
Fri Mar 13 12:51:43 AEDT 2020
On Thu, Mar 12, 2020 at 08:20:34PM -0500, Segher Boessenkool wrote:
> On Fri, Mar 13, 2020 at 11:31:46AM +1100, Alexey Kardashevskiy wrote:
> > >>> It now also calls virtio-serial-shutdown if it never was initialised?
> > >>
> > >> No. This also removes "['] shutdown add-quiesce-xt" so the only way to
> > >> end up in "shutdown" is having open-count incremented == open virtio-serial.
> > >
> > > Anything can call shutdown, the nice simple name encourages that even.
> > > It's not a good idea to make this word more fragile, imho.
> > In practice, one would need to run a guest with virtio-serial but not
> > make it default stdout to avoid having it initialized, then select
> > virtio-serial device in the SLOF prompt and call its "shutdown" method.
> > This nice simple name is not that easily accessible ;)
> Well, that depends on the user ;-)
(I mean, it can be called as just
apply shutdown disk0
or similar -- with "disk0" a device alias -- this is slightly harder to
do on an _open_ device, i.e. on an instance, but that isn't really hard
More information about the SLOF