[SLOF] [PATCH 2/3] virtio-serial: Rework shutdown sequence

Segher Boessenkool segher at kernel.crashing.org
Tue Mar 10 11:35:36 AEDT 2020


On Mon, Mar 09, 2020 at 11:43:12PM +0100, Greg Kurz wrote:
> --- a/board-qemu/slof/virtio-serial.fs
> +++ b/board-qemu/slof/virtio-serial.fs
> @@ -19,13 +19,8 @@ virtio-setup-vd VALUE virtiodev
>  \ Quiescence the virtqueue of this device so that no more background
>  \ transactions can be pending.
>  : shutdown  ( -- )
> -    initialized? IF
> -        my-phandle node>path open-dev ?dup IF
> -            virtiodev virtio-serial-shutdown
> -            close-dev
> -        THEN
> -        FALSE to initialized?
> -    THEN
> +    virtiodev virtio-serial-shutdown
> +    FALSE to initialized?
>  ;

It now also calls  virtio-serial-shutdown  if it never was initialised?

(Rest looks perfectly reasonable).


Segher


More information about the SLOF mailing list