[SLOF] [PATCH slof] fdt: Avoid recursion when traversing tree

Thomas Huth thuth at redhat.com
Fri Jul 17 21:45:53 AEST 2020


On 17/07/2020 13.02, Alexey Kardashevskiy wrote:
> 
> 
> On 17/07/2020 20:28, Segher Boessenkool wrote:
>> On Fri, Jul 17, 2020 at 07:39:53PM +1000, Alexey Kardashevskiy wrote:
>>> Well, this too but it is just some waiting :)
>>>
>>>> you seem to be talking about dysfunction of SLOF, which would be caused
>>>> by stack exhaustion if I understand Segher's anwser correctly, right ?
>>>
>>>
>>> Right. I am a bit surprised SLOF did not barf with "stack overflow" though.
>>
>> I do not know the current state of this well, so apply salt as needed...
>>
>> It is much too much overhead to check the stack pointer always
>> (executing a single virtual machine insn is just a handful of real
>> machine instructions!) 
> 
> 
> This all true but yet there is "ERROR: stack overflow in engine()" and I
> saw these in the past, and there others. But I never got to understand
> it completely their limits, Thomas would probably know.

IIRC that is issued by a check at the beginning of engine(), i.e. you'll
only see that if you e.g. call from Forth into C code and that calls
back into Forth via engine().

 Thomas



More information about the SLOF mailing list