[SLOF] [PATCH v5 7/7] tcgbios: Implement menu to clear TPM 2 and activate its PCR banks

[Segher Boessenkool]

Hi!

On Fri, Jan 10, 2020 at 08:21:55PM -0500, Stefan Berger wrote:
> --- a/board-qemu/slof/OF.fs
> +++ b/board-qemu/slof/OF.fs
> @@ -175,6 +175,9 @@ CREATE version-str 10 ALLOT
>      version-str 8 + @               \ end
>      over - dump-display-write
>      " Press 's' to enter Open Firmware." dump-display-write
> +    s" /ibm,vtpm" find-node IF
> +        "  Press 't' to enter TPM menu." terminal-write drop
> +    THEN

Why  terminal-write  , when the code just above uses  dump-display-write
instead?

> +: (t-pressed) ( -- )
> +   s" /ibm,vtpm" find-node dup IF
> +      s" vtpm-menu" rot $call-static
> +   ELSE
> +      drop
> +   THEN
> +;

: (t-pressed) ( -- )
   s" /ibm,vtpm" find-node ?dup IF
      s" vtpm-menu" rot $call-static
   THEN
;

(This is the prime reason  ?dup  exists at all :-) )


Segher