[SLOF] [PATCH slof] pci: Align PCI node names with QEMU
aik at ozlabs.ru
Tue Oct 22 12:13:02 AEDT 2019
On 22/10/2019 11:03, Segher Boessenkool wrote:
> On Tue, Oct 22, 2019 at 10:31:12AM +1100, Alexey Kardashevskiy wrote:
>> On 21/10/2019 20:41, Segher Boessenkool wrote:
>>> On Mon, Oct 21, 2019 at 06:02:12PM +1100, Alexey Kardashevskiy wrote:
>>>> @@ -176,14 +149,14 @@
>>>> 0310 OF s" usb-ohci" ENDOF
>>>> 0320 OF s" usb-ehci" ENDOF
>>>> 0330 OF s" usb-xhci" ENDOF
>>>> - 0380 OF s" usb" ENDOF
>>>> + 0380 OF s" usb-unknown" ENDOF
>>> "usb-unknown" is a much worse name.
>> Disagree, for something we do not really expect to see (what is this 380 device anyway?), it is an alarming enough name.
> So why have a name for all those you do not expect to see at all,
Well, this is to avoid changing QEMU :)
> by that
> same argument? You could easily display "pci-class-0c0380" or similar for
> the 98% of codes you do not expect to ever see.
The scope of the patch is to make SLOF names match QEMU names. Fixing names themselves is another topic which this patch
is not addressing.
More information about the SLOF