[SLOF] [PATCH slof] pci: Align PCI node names with QEMU

Alexey Kardashevskiy aik at ozlabs.ru
Tue Oct 22 10:31:12 AEDT 2019



On 21/10/2019 20:41, Segher Boessenkool wrote:
> On Mon, Oct 21, 2019 at 06:02:12PM +1100, Alexey Kardashevskiy wrote:
>>          0500  OF s" sd-host-conrtoller"   ENDOF
>>          dup   OF s" system-periphal"      ENDOF
> 
> Both these names have typos.

ouch.

> 
>> @@ -176,14 +149,14 @@
>>          0310  OF s" usb-ohci"      ENDOF
>>  	0320  OF s" usb-ehci"      ENDOF
>>          0330  OF s" usb-xhci"      ENDOF
>> -        0380  OF s" usb"           ENDOF
>> +        0380  OF s" usb-unknown"   ENDOF
> 
> "usb-unknown" is a much worse name.


Disagree, for something we do not really expect to see (what is this 380 device anyway?), it is an alarming enough name.


> 
>> @@ -216,7 +187,7 @@
>>          02  OF s" satelite-audio"  ENDOF
>>          03  OF s" satelite-voice"  ENDOF
>>          04  OF s" satelite-data"   ENDOF
>> -        dup OF s" satelite-devoce" ENDOF
>> +        dup OF s" satelite-device" ENDOF
> 
> These all still have typos.

ah right. Thanks,


-- 
Alexey


More information about the SLOF mailing list