[SLOF] [PATCH slof] client: Load initramdisk location

Alexey Kardashevskiy aik at ozlabs.ru
Mon Nov 11 12:31:32 AEDT 2019



On 08/11/2019 21:26, Segher Boessenkool wrote:
> On Fri, Nov 08, 2019 at 07:34:39PM +1100, Alexey Kardashevskiy wrote:
>> +  s" linux,initrd-end" get-chosen IF decode-int -rot 2drop ELSE 0 THEN
>> +  s" linux,initrd-start" get-chosen IF decode-int -rot 2drop ELSE 0 THEN
> 
> I'd write  -rot 2drop  as  nip nip  .  Dunno if you find that simpler to
> read as well though :-)

Equally bad so I'll take yours since at least somebody finds it easier :)

> 
>> +  2dup - dup IF
>> +    ciregs >r4 !
>> +    ciregs >r3 !
>> +    drop
>> +  ELSE
>> +    3drop
>> +  THEN
> 
> ( end start )
> 2dup <> IF
>   tuck - ( start len )
>   ciregs >r4 !
>   ciregs >r3 !
> THEN
> 
> ?


Looks better, thanks for the review!

> 
> 
> Segher
> 

-- 
Alexey


More information about the SLOF mailing list