[SLOF] [PATCH slof v2] rtas: Integrate RTAS blob

Alexey Kardashevskiy aik at ozlabs.ru
Thu Jul 18 16:34:09 AEST 2019



On 18/07/2019 14:52, David Gibson wrote:
> On Wed, Jul 17, 2019 at 10:13:49AM +0200, Thomas Huth wrote:
>> On 17/07/2019 06.41, Alexey Kardashevskiy wrote:
>>> We implement RTAS as a simple binary blob which calls directly into QEMU
>>> via a custom hcall. So far we were relying on QEMU putting the RTAS blob
>>> to the guest memory with its location in linux,rtas-base/rtas-size.
>>>
>>> The problems with this are:
>>> 1. we need to peek a location in the guest ram in addition to slof, FDT
>>> and sometime kernel and init ram disk; having one less image makes QEMU's
>>> life easier.
>>> 2. for secure VMs, it is yet another image which needs to be signed and
>>> verified.
>>>
>>> This implements "instantiate-rtas" completely in SLOF, including KVM PR
>>> support ("broken sc1").
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
>>> ---
>>> Changes:
>>> v2:
>>> * fixed rtas for slof itself
>>> * removed rtas-entry as it is the same as rtas-base now
>>> * fixed style
>>> ---
>>>   lib/libhvcall/libhvcall.h |  5 +++++
>>>   lib/libhvcall/brokensc1.c |  2 +-
>>>   board-qemu/slof/rtas.fs   | 45 ++++++---------------------------------
>>>   lib/libhvcall/hvcall.S    | 21 ++++++++++++++++++
>>>   lib/libhvcall/hvcall.code | 14 ++++++++++++
>>>   lib/libhvcall/hvcall.in   |  1 +
>>>   6 files changed, 49 insertions(+), 39 deletions(-)
>>
>> Reviewed-by: Thomas Huth <thuth at redhat.com>
> 
> Reviewed-by: David Gibson <david at gibson.dropbear.id.au>
> 
> Let's go ahead with this, and I'll make the corresponding qemu changes
> in 4.2

I've posted https://patchwork.ozlabs.org/patch/1132443/ , are you 
planning something more or different than that?

Also, do you want a pull request for update slof now, or closed to the 
v4.2 soft freeze? Thanks,



-- 
Alexey


More information about the SLOF mailing list