[SLOF] [PATCH slof 1/2] fdt: Factor out code to replace a phandle in place

[Segher Boessenkool]

On Tue, May 29, 2018 at 05:59:14PM +1000, Alexey Kardashevskiy wrote:
> On 22/5/18 4:04 pm, Segher Boessenkool wrote:
> >>>> Maybe you could simply use the "4 - swap 4 + swap" directly here? It's
> >>>> only one line of code, so not sure whether it's worth to put this into a
> >>>> separate Forth word.
> >>>
> >>> "l," kind of allocates some bytes in some heap.
> >>
> >> But your "fdt-replace-l," does not allocate anything, it just increases
> >> an address on the stack and a size on the stack at the same time.
> > 
> > fdt-replace-l, is just
> > 
> >   /l /string
> > 
> > so it is much easier to understand if you just type that directly.
> 
> Is it? It is not a string I am advancing on and using something+string on
> that is misleading imho. I'll do simple "4 - swap 4 + swap".

"string" just means "memory region": an address and a length.  "/string"
shortens a memory region at the front (doing it at the end is just "-").


Segher