[SLOF] [PATCH v2 03/11] libnet: Pass tftp_retries and ip_version via struct filename_ip

Thomas Huth thuth at redhat.com
Fri May 25 14:28:01 AEST 2018

On 25.05.2018 04:57, Alexey Kardashevskiy wrote:
> On 25/5/18 12:26 am, Thomas Huth wrote:
>> On 24.05.2018 11:01, Alexey Kardashevskiy wrote:
> btw obp_tftp_args_t::filename[100] vs. filename_ip::filename[256] - it
> feels like the latter can be easily reduced to 140-ish (path + uuid) with
> no harm but probably this is for another day (both definitions came in the
> initial commit).

filename_ip::filename can also come from the DHCP code, so decreasing
its size might change the behavior wrt to DHCP.

>> If you're confused by the "filename_ip" name, we could maybe simply
>> rename that one to "netload_params" or "netload_args" instead ... or I
>> could simply revert that change in my patches so that we continue to
>> pass the tftp retries variable as normal function parameter instead...
>> just let me know what you prefer.
> Passing "retries" separately seems better.

Ok, will do.


More information about the SLOF mailing list