[SLOF] [PATCH v6 1/2] Fix output word
lvivier at redhat.com
Tue May 22 18:47:02 AEST 2018
On 14/05/2018 11:55, Alexey Kardashevskiy wrote:
> On 8/4/18 9:05 pm, Segher Boessenkool wrote:
>> On Fri, Apr 06, 2018 at 10:47:03AM +0200, Laurent Vivier wrote:
>>> : output ( dev-str dev-len -- )
>>> open-dev ?dup IF
>> It's a lot simple if you do an early exit if there is no such device.
>> You're supposed to output an error message in that case, fwiw.
>>> - \ Close old stdout:
>>> - s" stdout" get-chosen IF
>>> - decode-int nip nip ?dup IF close-dev THEN
>>> + \ find new ihandle and xt handle
>>> + dup s" write" rot ihandle>phandle find-method
>>> + 0= IF
>>> + drop
>>> + cr ." Cannot find the write method for the given output console " cr
>>> + EXIT
>> This leaks the instance.
> Laurent, you are reposting this patch with a fix, right? thanks.
Alexey, I've sent a v7 last week. It has been reviewed by Thomas.
Regarding the comments from Segher, I will not change the code because
review is clearer like that (not indentation changes), but if you commit
this series could you update the comment as he asks ("xt" instead of
More information about the SLOF