[SLOF] [PATCH v7 1/2] Fix output word
Laurent Vivier
lvivier at redhat.com
Fri May 18 01:29:15 AEST 2018
On 17/05/2018 17:12, Segher Boessenkool wrote:
> Hi!
>
> On Thu, May 17, 2018 at 03:16:03PM +0200, Laurent Vivier wrote:
>> We can select the console output, but it does not really work
>>
>> Implement term-io-emit, as we have term-io-key to really
>> send characters to the output selected by stdout.
>>
>> Resolve xt-handle and ihandle in the output command.
>
> Just "xt", not "xt-handle"?
>
>> : output ( dev-str dev-len -- )
>> open-dev ?dup IF
>
> open-dev dup 0= IF drop EXIT THEN
>
> is easier to read.
I keep the original code to keep the original indentation in the body of
the IF-THEN: it was a comment from Thomas for the v5 to get easier to
review.
> Looks good modulo those nits :-)
Thank you :)
Laurent
More information about the SLOF
mailing list