[SLOF] [PATCH 1/4] romfs/tools: Remove superfluous union around the rom header struct

Segher Boessenkool segher at kernel.crashing.org
Sun Jul 22 02:57:51 AEST 2018

On Fri, Jul 20, 2018 at 01:35:14PM +1000, Alexey Kardashevskiy wrote:
> On 20/7/18 2:43 am, Segher Boessenkool wrote:
> > The code is treating some binary data as a C struct.  Not a good idea at all,
> Besides missing "__attribute__ ((packed))", what is wrong with that?

It depends on the ABI you are currently using, which makes the code much
less portable than you may hope for.


More information about the SLOF mailing list