[SLOF] [PATCH v2 2/2] usb/storage: Implement block write support

Segher Boessenkool segher at kernel.crashing.org
Thu Dec 13 20:13:13 AEDT 2018

On Thu, Dec 13, 2018 at 09:13:55AM +0100, Laurent Vivier wrote:
> On 12/12/2018 22:10, Segher Boessenkool wrote:
> > On Wed, Dec 12, 2018 at 09:14:21PM +0100, Thomas Huth wrote:
> >> On 2018-12-12 15:31, Laurent Vivier wrote:
> >> There is another "ELSE FALSE EXIT THEN" at the end of this function. I
> >> think you've got to drop the "dir" stack item in that case, too, don't you?
> > 
> > Early exits should be early, not late.  That's the point of early exits:
> > it reduces nesting level, and confusion about what is on the stacks when.
> In fact, the "EXIT" Thomas is speaking about is at the top of the
> function, it's why we have to drop the "dir" stack item: it has not been
> used. The latest version of the series is v4.

For some reason the v2 showed up as newer in my mail.  Dunno :-)


More information about the SLOF mailing list