[SLOF] [PATCH v4 0/2] Fix output word

[Laurent Vivier]

On 05/04/2018 07:40, Alexey Kardashevskiy wrote:
> On 23/3/18 9:15 pm, Laurent Vivier wrote:
>> This patch fixes the output word, and allow to select the console.
>> It updates input word in the same way.
>>
>> For the moment it works well while we don't mix serial port console
>> with VGA console or virtio-console (there is a special case for VGA
>> console that overwrite without condition the emit word, see
>> 9b89b28 "Add support for qemu standard VGA". Im' working on this).
>>
>> You can test it with:
>>
>> qemu-system-ppc64 -nodefaults -nographic \
>>   -chardev socket,id=serial_id_serial0,host=localhost,port=4441,telnet,server,wait \
>>   -device spapr-vty,chardev=serial_id_serial0 \
>>   -chardev socket,id=serial_id_serial1,host=localhost,port=4442,telnet,server,wait \
>>   -device spapr-vty,chardev=serial_id_serial1 \
>>   -monitor stdio
>>
>> Connect on the two ports with "telnet localhost 4441" and "telnet 4442".
>>
>> Once it is done you will see on the first console the SLOF logs.
>> Then, in the first console:
>>
>>     " /vdevice/vty at 71000002" input
>>
>> Now what you write on second console is written on the first one.
>>
>> To send the characters to the second one, we should use:
>>
>>     " /vdevice/vty at 71000002" output
>>
>> but it doesn't work and this patch fixes that.
>>
>> A shortcut for these two commands is:
>>
>>     " /vdevice/vty at 71000002" io
>>
>> v4:
>>   - use variables to store stdin and stdout ihandle (rename them)
>>   - introduce set-stdin and set-stdout
>>   - update error message
> 
> 
> I have a problem with these patches. They fix the problem and work as
> promised, good job, thanks!
> 
> However in order to push it out, I need to either understand precisely what
> they are doing OR have Thomas and/or Segher's "reviewed-by".
> 
> For example, the 1/2 seems to have 2 changes:
> - start using the "stdout" variable;
> - print to the correct terminal.
> 
> 2/2 is even bigger (amount of comments gives a hint), and it looks like a
> mixture of re-indent and a bugfix.
> 
> Is that just me and everybody else can easily read it? :)

I've just sent a new series, trying to make this clearer...

Thanks,
Laurent