[SLOF] [PATCH slof v5 3/6] fdt: Pass the resulting device tree to QEMU
segher at kernel.crashing.org
Wed Oct 18 20:46:48 AEDT 2017
On Wed, Oct 18, 2017 at 08:34:57PM +1100, Alexey Kardashevskiy wrote:
> > Or even not define words for the phandle and ihandle if you don't use
> > them. Your choice :-)
> I need either:
> - a variable for the unit address or
> - a word to get it ("chosen-cpu-unit").
> They both are better be defined nearby set-chosen-cpu. But fdt.fs is parsed
> before that.
Well, set-chosen-cpu shouldn't really decide what the boot cpu is
anyway -- it should just set the link in /chosen!
The current method of just picking whatever is the first device in /cpus
isn't so great anyway.
> My choice was to do "defer chosen-cpu-unit" but you are opposing it which
> makes me think I am missing something, again :)
I'm not opposing it, just suggesting ways to make it better. In general
having DEFERs for random stuff means you should do some restructuring, or
you'll end up with spaghetti (and things build with spaghetti aren't
typically very sturdy).
More information about the SLOF