[SLOF] [PATCH slof v3 5/5] fdt: Pass the resulting device tree to QEMU

Segher Boessenkool segher at kernel.crashing.org
Sat Oct 14 11:34:37 AEDT 2017


Hi Alexey,

On Sat, Oct 14, 2017 at 11:24:05AM +1100, Alexey Kardashevskiy wrote:
> >> +    dup >r
> >> +    >fdth_tsize l@              ( buf len size r: dtb )
> >> +    min                         ( buf minsize r: dtb )
> >> +    r@ -rot
> >> +    move
> >> +
> >> +    r> fdt-flatten-tree-free
> >> +
> >> +    0
> >> +;
> > 
> > That "min" isn't correct I think -- if the DTB doesn't fit, you want to
> > complain loudly and/or return an error to the caller.
> 
> Well, this is not a real patch, this is an RFC to hear about the idea in
> general. I'll add a complain here if we decide it is worth doing.

Returning an error is more important (and probably enough, the kernel is
in control at this point).


Segher


More information about the SLOF mailing list