[SLOF] [PATCH slof v3 2/5] Revert "libhvcall: drop unused KVMPPC_H_REPORT_MC_ERR and KVMPPC_H_NMI_MCE defines"
david at gibson.dropbear.id.au
Tue Oct 3 17:15:43 AEDT 2017
On Tue, Oct 03, 2017 at 04:15:20PM +1100, Alexey Kardashevskiy wrote:
> This reverts commit 089fc18a9b
> "libhvcall: drop unused KVMPPC_H_REPORT_MC_ERR and KVMPPC_H_NMI_MCE defines"
> as a bigger hammer is coming soon
> which will pass the entire device tree to QEMU, not just phandles.
> QEMU has never used the hcall this patch is removing so there will
> be no compatibility issues.
> Signed-off-by: Alexey Kardashevskiy <aik at ozlabs.ru>
Yeah. These probably shouldn't have been committed to SLOF without
the corresponding qemu code being at least acked in principle. After
all, the qemu source is effectively the authoritative source for what
the vendor specific hcalls are.
> lib/libhvcall/libhvcall.h | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/lib/libhvcall/libhvcall.h b/lib/libhvcall/libhvcall.h
> index b2ea3f6..193b738 100644
> --- a/lib/libhvcall/libhvcall.h
> +++ b/lib/libhvcall/libhvcall.h
> @@ -25,6 +25,8 @@
> /* Client Architecture support */
> #define KVMPPC_H_CAS (KVMPPC_HCALL_BASE + 0x2)
> #define KVMPPC_H_RTAS_UPDATE (KVMPPC_HCALL_BASE + 0x3)
> +#define KVMPPC_H_REPORT_MC_ERR (KVMPPC_HCALL_BASE + 0x4)
> +#define KVMPPC_HCALL_MAX KVMPPC_H_NMI_MCE
> #ifndef __ASSEMBLY__
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 833 bytes
Desc: not available
More information about the SLOF